Joe Perches <[EMAIL PROTECTED]> :
[...]
> > - if ((sp->LED_Mode & 0x01) == 1)
> > + if ((sp->led_mode & 0x01) == 1)
>
> I think the use of hex and decimal constants is odd.
> I think "if (sp->led_mode & 0x01)" is better.
Yes, the whole context of this code in the driver is a bit special.
[...]
> > /* Assign IPG_APPEND_FCS_ON_TX > 0 for auto FCS append on TX. */
> > -#define IPG_APPEND_FCS_ON_TX TRUE
> > +#define IPG_APPEND_FCS_ON_TX 1
>
> Why not true and false?
No objection. Both can be used.
[...]
> > @@ -753,8 +732,7 @@ enum ipg_regs {
> > * Miscellaneous macros.
> > */
> >
> > -/* Marco for printing debug statements.
> > -# define IPG_DDEBUG_MSG(args...) printk(KERN_DEBUG "IPG: " ## args) */
> > +/* Marco for printing debug statements. */
>
> Macros
I actively ignored it. It was not easy. :o)
--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
