On Tue, Dec 11, 2007 at 04:40:16AM -0800, David Miller wrote: > > I bet the __xfrm_lookup() callers could stand a major audit, with the > special -EREMOTE logic I bet there are non-EREMOTE code paths there > that don't handle the dst ref semantics properly. > > This is a very error prone interface, both at the implementation > and in the callers.
Heh, didn't we already do an audit a couple of years ago when we made the decision that the dst is always going to be freed in case of an error? But yeah another audit for this and EREMOTE wouldn't hurt. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
