On Tue, 11 Dec 2007, Christoph Hellwig wrote:
> On Tue, Dec 11, 2007 at 01:50:39PM +0200, Ilpo J?rvinen wrote:
> > + BUG_ON((prev != NULL) && !tcp_skb_adjacent(sk, prev,
> > skb[queue]));
> > +
> > + tcp_for_write_queue_from(skb[queue], sk, queue) {
> > + if ((prev != NULL) && !tcp_skb_adjacent(sk, prev,
> > skb[queue]))
> > + break;
> > +
> > + if (!before(TCP_SKB_CB(skb[queue])->seq,
> > tcp_sk(sk)->snd_nxt) ||
> > + TCP_SKB_CB(skb[queue])->fack_count == fc)
> > + return;
>
> There's quite a few overflows of the normal 80 char limit here. Because
> you're current style is a little on the verbose side that's trivially
> fixable, though:
This part got removed when part of TCP code got removed during net-2.6.25
rebase...
Thanks anyway for the reminder, I'll try to be more careful during code
moves in future but I'll probably continue to allow expections in cases
where the offenders only consist of closing parenthesis, block opening
brace and termination semicolon (like it was in one of these lines as
well).
--
i.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
