I agree.
I mistakenly thought hz in that context must be larger than 1000..
As it's uncertain, your's looks much simpler and better.
(btw, the lines "else .... div = 1" is not needed, is it?)
Thanks,
Satoru SATOH
2007/12/21, YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]>:
(snip)
> Why don't you simply use unsigned long long (or maybe uint64_t) here?
>
> Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]>
>
> ---
> diff --git a/ip/iproute.c b/ip/iproute.c
> index f4200ae..db9a3b6 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -509,16 +509,21 @@ int print_route(const struct sockaddr_nl *who, struct
> nlmsghdr *n, void *arg)
> i != RTAX_RTO_MIN)
> fprintf(fp, " %u",
> *(unsigned*)RTA_DATA(mxrta[i]));
> else {
> - unsigned val = *(unsigned*)RTA_DATA(mxrta[i]);
> + unsigned long long val =
> *(unsigned*)RTA_DATA(mxrta[i]);
> + unsigned div = 1;
>
> - val *= 1000;
> if (i == RTAX_RTT)
> - val /= 8;
> + div = 8;
> else if (i == RTAX_RTTVAR)
> - val /= 4;
> - if (val >= hz)
> - fprintf(fp, " %ums", val/hz);
> + div = 4;
> else
> + div = 1;
> +
> + val = val * 1000ULL / div;
> +
> + if (val >= hz) {
> + fprintf(fp, " %llums", val/hz);
> + } else
> fprintf(fp, " %.2fms", (float)val/hz);
> }
> }
>
> --yoshfuji
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
