Randy Dunlap wrote: > On Fri, 21 Dec 2007 16:53:40 +0000 Robert Stonehouse wrote: > > > This is a resubmission of a new driver for Solarflare network controllers. <snip> > > The last two patches were marked with RFC but I now think that this driver > > is ready (withstanding any further review comments) and I would like to ask > > that this driver is considered for merging. > > > > > > The patch (against net-2.6.25) is at: > > https://support.solarflare.com/netdev/3/net-2.6.25-sfc-2.2.0029.patch > > wow, 750+ KB > > How many drivers is this?
Just two: sfc (net) and sfc_mtd (MTD). As Robert said, the net driver supports a variety of PHYs. It also has a fair amount of self-test and (conditional) debug code, and comments. I've noted your comments on kernel-doc and Kconfig format and will address those in the next version. <snip> > c. Driver contains MTD, SPI, & I2C (at least) code and needs to be > reviewed by people in those areas as well (IMO). > > I see an MTD dependency in the Kconfig file. > What about the SPI and I2C parts? Are they conditional or > how is that handled? or does the driver not use the kernel > infrastructure for these? We are not currently using the kernel infrastructure for those. I'm not sure whether we could do. I think everyone working on the net driver here will be away until the new year, so please forgive our silence in the mean time. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
