On Thu, Jan 10, 2008 at 03:32:28PM -0800, Kok, Auke wrote: > - cleaned up largely against sparse, checkpatch
largely means not completely, right? Please make sure there's no sparse warnings left at least. checkpatch is not that criticial, but it would be good to have an explanation for everything left. some comments on the patch - please remove that sill copyright heder on the Makefile, it's hard to claim any rights on a trivial 3 line makefile. - also please use igb-y instead of igb-objs in the Makefile - the driver would be a lot more readable (and more importantly hackable) if it was written in a natural flow instead of having dozends of lines of forward declarations in every file. - so you're adding your own phy abstraction. Is there a good reason you can't simply use the generic phylib? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
