From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Sun, 13 Jan 2008 11:33:01 +0100

>    CHECK   net/x25/af_x25.c
> net/x25/af_x25.c:117:46: warning: expensive signed divide
>    CHECK   net/x25/x25_facilities.c
> net/x25/x25_facilities.c:209:30: warning: expensive signed divide
>    CHECK   net/x25/x25_in.c
> net/x25/x25_in.c:250:26: warning: expensive signed divide
>    CHECK   net/x25/x25_proc.c
> net/x25/x25_proc.c:48:11: warning: context imbalance in 'x25_seq_route_start' 
> - wrong count at exit
> net/x25/x25_proc.c:72:13: warning: context imbalance in 'x25_seq_route_stop' 
> - 
> unexpected unlock
> net/x25/x25_proc.c:112:11: warning: context imbalance in 
> 'x25_seq_socket_start' - wrong count at exit
> net/x25/x25_proc.c:129:13: warning: context imbalance in 
> 'x25_seq_socket_stop' 
> - unexpected unlock
> net/x25/x25_proc.c:190:11: warning: context imbalance in 
> 'x25_seq_forward_start' - wrong count at exit
> net/x25/x25_proc.c:215:13: warning: context imbalance in 
> 'x25_seq_forward_stop' - unexpected unlock
>    CHECK   net/x25/x25_subr.c
> net/x25/x25_subr.c:362:57: warning: expensive signed divide
> 
> Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]>

Applied, thanks Eric.

We might just want to make sk_rcvbuf et al. unsigned, it
crops up a lot and I can't see any valid reason for it
to be negative or for uses of it to matter with other
signed values.

Or did we discuss that to death already? :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to