On Wed, Jan 30, 2008 at 03:22:51AM -0500, Jeff Garzik wrote:
> Sam Ravnborg wrote:
> >On Tue, Jan 29, 2008 at 11:03:10PM +0100, Francois Romieu wrote:
> >>maximilian attems <[EMAIL PROTECTED]> :
> >>> CC [M] drivers/net/sis190.o
> >>> drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type
> >>> conflict
> >>> make[5]: *** [drivers/net/sis190.o] Error 1
> >>>
> >>>gcc --version
> >>>gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)
> >
> >Looks like a bug where __initdata has been used
> >for const data.
> >Searching:
> >static int __devinit sis190_get_mac_addr_from_apc(struct pci_dev *pdev,
> > struct net_device *dev)
> >{
> > static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 };
> > struct sis190_private *tp = netdev_priv(dev);
> > struct pci_dev *isa_bridge;
> > u8 reg, tmp8;
> >
> >Try to change this is __initconst and it should be fixed.
>
> We have __initconst now?
>
> Three cheers, and a beer, to whomever did that...
I will hand over the cheers to Jan Beulich and drink the beer myself ;-)
Sam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
