On Fri, 2008-02-08 at 09:52 -0800, Andrew Morton wrote:
> On Fri, 08 Feb 2008 08:59:10 -0500 David Dillow <[EMAIL PROTECTED]> wrote:
> > On Fri, 2008-02-08 at 03:11 -0800, [EMAIL PROTECTED] wrote:
> > > From: Andrew Morton <[EMAIL PROTECTED]>
> > >
> > > gcc-3.4.4 on powerpc:
> > >
> > > drivers/net/typhoon.c:137: error: version causes a section type conflict
> > >
> > > Cc: Jeff Garzik <[EMAIL PROTECTED]>
> > > Cc: Sam Ravnborg <[EMAIL PROTECTED]>
> > > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
> >
> > > -static const char version[] __devinitdata =
> > > +static char version[] __devinitdata =
> > > "typhoon.c: version " DRV_MODULE_VERSION " (" DRV_MODULE_RELDATE
> > > ")\n";
> >
> > Wouldn't going to __devinitconst be better? I'll try to whip up a patch
> > and test-compile it.
>
> Sam told me that doesn't work right, that this approach is the one to use
> and, iirc, that __devinitcont and friends will be removed.
>
> I'm not sure why, actually. I think I missed that dicussion.
Thanks for the searchable terms -- this is the thread, I think:
http://lkml.org/lkml/2008/2/3/99
It looks like Jan had an idea to fold the const into the __devinitconst
marker, and if that seems to be viable, then I'd prefer that route to
keep the const'ness where it is possible.
Otherwise, your patch is fine as-is.
Acked-by: David Dillow <[EMAIL PROTECTED]>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
