Stephen Hemminger <[EMAIL PROTECTED]> wrote:
>Get rid of warning and simplify code that looks up vlan tag.
>No need to get tag, then copy it. Also no need for a local status
>variable.
Granted, the current code is suboptimal, but I don't see any
warnings compiling this (gcc 4.1.2). What are you getting?
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
>Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
>---
>Patch against current 2.6.25 version.
>
>--- a/drivers/net/bonding/bond_alb.c 2008-02-18 20:58:53.000000000 -0800
>+++ b/drivers/net/bonding/bond_alb.c 2008-02-18 21:01:10.000000000 -0800
>@@ -678,12 +678,8 @@ static struct slave *rlb_choose_channel(
> }
>
> if (!list_empty(&bond->vlan_list)) {
>- unsigned short vlan_id;
>- int res = vlan_get_tag(skb, &vlan_id);
>- if (!res) {
>+ if (!vlan_get_tag(skb, &client_info->vlan_id))
> client_info->tag = 1;
>- client_info->vlan_id = vlan_id;
>- }
> }
>
> if (!client_info->assigned) {
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to [EMAIL PROTECTED]
>More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
