On Thu, Feb 21, 2008 at 1:00 AM, Nicolas Pitre <[EMAIL PROTECTED]> wrote: > On Wed, 20 Feb 2008, Magnus Damm wrote: > > > This patch makes sure SMC_insw()/SMC_outsw() are defined for the > > default configuration. Without this change BUG()s will be triggered > > when using 16-bit only platform data and the default configuration. > > > > Signed-off-by: Magnus Damm <[EMAIL PROTECTED]> > > You should have introduced this patch as 3/4 instead of 4/4 so to make > sure the series won't create a non functional kernel between 3/4 and > 4/4.
Yes, you are right. At least in theory. =) In practice this doesn't matter so much since the boards modified by 3/4 are all in a half-assed state. I'm working on fixing that up though, and using platform data flags would be help a lot. =) Speaking of smc91x and sh-boards, I guess the patch below is too late for 2.6.25? We have the rest of the board support bits in place already but no ethernet. I posted the smc91x patch below a bit too late unfortunately _and_ i forgot to CC you, so my bad. http://www.mail-archive.com/netdev@vger.kernel.org/msg61390.html Thanks for your help! / magnus -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
