On Thu, 2008-02-21 at 01:57 -0800, David Miller wrote: > From: Harvey Harrison <[EMAIL PROTECTED]> > Date: Thu, 21 Feb 2008 01:34:27 -0800 > > > commit 0795af5729b18218767fab27c44b1384f72dc9ad > > Author: Joe Perches <[EMAIL PROTECTED]> > > Date: Wed Oct 3 17:59:30 2007 -0700 > > > > [NET]: Introduce and use print_mac() and DECLARE_MAC_BUF() > > > > This is nicer than the MAC_FMT stuff. > > > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > > Signed-off-by: David S. Miller <[EMAIL PROTECTED]> > > > > Introduced: > > net/mac80211/debugfs_sta.c: In function ‘ieee80211_sta_debugfs_add’: > > net/mac80211/debugfs_sta.c:211: warning: statement with no effect > > > > Does print_mac modify the mac buffer in-place, or return a new buffer? > > It modifies the buffer in place. > > The warning is likely not from Joe's patch, but more likely > from the __pure attribute I recently added to print_mac()'s > declaration. If so, we'll need to perhaps rework things.
In this case, it's being passed to a debugfs create function, could it instead use sysfs_format_mac? Harvey -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
