From: Jon Maloy <[email protected]> Date: Tue, 28 Apr 2015 16:59:04 -0400
> Currently, we try to accumulate arrived packets in the links's > 'deferred' queue during the parallel link syncronization phase. > > This entails two problems: > > - With an unlucky combination of arriving packets the algorithm > may go into a lockstep with the out-of-sequence handling function, > where the synch mechanism is adding a packet to the deferred queue, > while the out-of-sequence handling is retrieving it again, thus > ending up in a loop inside the node_lock scope. > > - Even if this is avoided, the link will very often send out > unnecessary protocol messages, in the worst case leading to > redundant retransmissions. > > We fix this by just dropping arriving packets on the upcoming link > during the synchronization phase, thus relying on the retransmission > protocol to resolve the situation once the two links have arrived to > a synchronized state. > > Reviewed-by: Erik Hugne <[email protected]> > Reviewed-by: Ying Xue <[email protected]> > Signed-off-by: Jon Maloy <[email protected]> Applied, thanks Jon. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
