Mon, May 11, 2015 at 02:08:34PM CEST, [email protected] wrote: >On 05/09/15 09:10, Jiri Pirko wrote: >>This patch introduces a flow-based filter. So far, the very essential >>packet fields are supported. >> >>This patch is only the first step. There is a lot of potential performance >>improvements possible to implement. Also a lot of features are missing >>now. They will be addressed in follow-up patches. >> >>Signed-off-by: Jiri Pirko <[email protected]> > >I have a question Jiri: What kind of flower is this? ;->
Just a generic flower :) >Very nice - Glad Dave pushed you to go this direction. >For a usable classifier that performs reasonably well, i think >this one is going to look good. > >My suggestion is to not add TCA_FLOWER_POLICE attribute. >Policers can be added via TCA_FLOWER_ACT (which is the modern >way to do it). Infact i would suggest even in your iproute2 >code, please kill the conditional that tries to parse for >TCA_FLOWER_POLICE > >Other than that: >Acked-by: Jamal Hadi Salim <[email protected]> Okay, thanks. Will send v2 without TCA_FLOWER_POLICE. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
