From: Amir Vadai <[email protected]>
Date: Sun, 10 May 2015 12:38:57 +0300
> +int mlx5_rename_eq(struct mlx5_core_dev *dev, int eq_ix, char *name)
> +{
> + struct mlx5_priv *priv = &dev->priv;
> + struct mlx5_eq_table *table = &priv->eq_table;
> + struct mlx5_eq *eq;
> + int err = -ENOENT;
> +
> + spin_lock(&table->lock);
> + list_for_each_entry(eq, &table->comp_eqs_list, list) {
> + if (eq->index == eq_ix) {
> + snprintf(priv->irq_info[eq_ix].name, MLX5_MAX_IRQ_NAME,
> + "%s-%d", name, eq_ix);
> + err = 0;
> + break;
> + }
> + }
> + spin_unlock(&table->lock);
> +
> + return err;
> +}
You have to be very careful with this.
If you change these names after the request_irq() call(s), the new name string
will not propagate to /proc/interrupts output etc.
Looking at your later patches, this seems to be invoked very late in
mlx5e_open_locked(), so I am concerned.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
