From: Tom Herbert <t...@herbertland.com>
Date: Tue, 12 May 2015 08:22:58 -0700
> @@ -15,6 +15,13 @@
> * All the members, except thoff, are in network byte order.
> */
> struct flow_keys {
> + u16 thoff;
> + u16 padding1;
> +#define FLOW_KEYS_HASH_START_FIELD n_proto
> + __be16 n_proto;
> + u8 ip_proto;
> + u8 padding;
> +
This padding works if everyone consistently zero initializes the whole
key structure, but for whatever reason (performance, unintentional
oversight, etc.) not all paths do.
So, for example, inet_set_txhash() is going to have random crap in
keys.padding, so the hashes computed are not stable for a given flow
key tuple.
That's just the first code path I found with this issue, there are
probably several others.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
