From: Edward Cree <ec...@solarflare.com> Date: Wed, 20 May 2015 16:49:09 +0100
> This patchset adds support for logging MCDI (Management-Controller-to- > Driver Interface) interactions between the sfc driver and a bound device, > to aid in debugging. > Solarflare has a tool to decode the resulting traces and will look to > open-source this if there is any external interest, but the protocol is > already detailed in drivers/net/ethernet/sfc/mcdi_pcol.h. > > v2: avoid long lines in cover letter; fix multiline comment style All of this work to allocate the buffer, add messages to it, and dump it to some user obtainable location duplicates existing infrastructure in the kernel. Please do not do this, and instead use the kernel's existing tracing infrastructure to implement this. I do not care how much time and effort you've already invested in your existing tool, you should have thought about that when designing this in the first place. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
