From: Vadim Kochan <vadi...@gmail.com>

Use strdup instead of malloc, and get rid of bad strcpy.

Signed-off-by: Vadim Kochan <vadi...@gmail.com>
---
 misc/ss.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/misc/ss.c b/misc/ss.c
index 347e3a1..a719466 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -1908,8 +1908,7 @@ static void tcp_show_info(const struct nlmsghdr *nlh, 
struct inet_diag_msg *r,
 
                if (tb[INET_DIAG_CONG]) {
                        const char *cong_attr = 
rta_getattr_str(tb[INET_DIAG_CONG]);
-                       s.cong_alg = malloc(strlen(cong_attr + 1));
-                       strcpy(s.cong_alg, cong_attr);
+                       s.cong_alg = strdup(cong_attr);
                }
 
                if (TCPI_HAS_OPT(info, TCPI_OPT_WSCALE)) {
-- 
2.3.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to