From: Shradha Shah <[email protected]> Date: Mon, 1 Jun 2015 14:00:12 +0100
> In the case where we have multiple functions (PFs and VFs), this > sysfs entry is useful to identify the physical port corresponding > to the function we are interested in. > > Signed-off-by: Shradha Shah <[email protected]> This is a low effort change. You retained all of the error handling changes that were only necessary when you added the new sysfs file, but are completely unnecessary if you're just reporting it via netdev->dev_port. This is extremely disappointing, because you expect me to put a good effort into reviewing your changes yet you aren't putting that level of effort into the submission itself. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
