> On Jun 2, 2015, at 10:48 AM, Alexander Duyck <alexander.h.du...@redhat.com> > wrote: > > I'm pretty sure these could cause some serious errors if you direct assign > the device into a VM since you then end up with multiple devices sharing a > bus. Also it would likely have side-effects on a LOM (Lan On Motherboard) as > it also shares the bus with multiple non-Ethernet devices. > > I believe you still need to add something like a check for > !pci_is_root_bus(dev->bus) before you attempt to grab function 0. It > probably also wouldn't hurt to check the dev->multifunction bit before > running this code since it wouldn't make sense to go chasing down the VPD on > another function if the device doesn't have one. You could probably do that > either as a part of this code, or perhaps put it in the quirk.
I'll look into those. I think you are right about more checks being needed. Thanks for the comments. -- Mark Rustad, Networking Division, Intel Corporation
signature.asc
Description: Message signed with OpenPGP using GPGMail
