On Thu, Jun 4, 2015 at 1:13 AM, David Miller <da...@davemloft.net> wrote:
> From: Neil McKee <neil.mc...@inmon.com>
> Date: Wed,  3 Jun 2015 15:31:07 -0700
>
>> Back out the OVS_USERSPACE_ATTR_ACTIONS attribute that was
>> gating the inclusion of datapath actions in the upcall.
>> Instead include the actions every time, provided there is no
>> problem with the atomic allocation.  If the atomic allocation
>> fails then try it again with the actions omitted.
>>
>> Signed-off-by: Neil McKee <neil.mc...@inmon.com>
>
> Conditionally providing the attributes to the user is completely
> terrible semantics.
>
> If the user really needs these, then he won't be happy to get the
> upcall without them, he'd rather the upcall fail completely
> instead.
>
> I'm not applying this patch, this change was not well thought out
> at all.

OK.  We can use the OVS_USERSPACE_ATTR_ACTIONS mechanism that you
checked in already.   Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to