On Thu, Jun 18, 2015 at 03:26:30AM -0700, David Miller wrote:
> From: Andy Gospodarek <go...@cumulusnetworks.com>
> Date: Mon, 15 Jun 2015 12:33:19 -0400
>
> > @@ -1107,9 +1107,10 @@ static int fib_netdev_event(struct notifier_block
> > *this, unsigned long event, vo
> > struct net_device *dev = netdev_notifier_info_to_dev(ptr);
> > struct in_device *in_dev;
> > struct net *net = dev_net(dev);
> > + unsigned flags;
>
> Please always fully spell out "unsigned int" instead of shortening it to
> just "unsigned", thanks.
>
> > @@ -920,11 +926,17 @@ struct fib_info *fib_create_info(struct fib_config
> > *cfg)
> > if (!nh->nh_dev)
> > goto failure;
> > } else {
> > + int linkdown = 0;
> > change_nexthops(fi) {
>
> Please put an empty line between local variable declarations and
> code.
Ugh, thanks. I'll fixup this and your other comments with v5.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
