I have three nits to pick...
On Thu, Jul 02, 2015 at 06:14:48PM -0700, Christopher Hall wrote:
> diff --git a/include/linux/ptp_clock_kernel.h
> b/include/linux/ptp_clock_kernel.h
> index b8b7306..344f129 100644
> --- a/include/linux/ptp_clock_kernel.h
> +++ b/include/linux/ptp_clock_kernel.h
> @@ -67,6 +67,11 @@ struct ptp_clock_request {
> * @gettime64: Reads the current time from the hardware clock.
> * parameter ts: Holds the result.
> *
> + * @getsynctime64: Reads the current time from the hardware clock and system
> + * clock simultaneously.
> + * parameter dev: Holds the device time
> + * parameter sys: Holds the system time
> + *
> * @settime64: Set the current time on the hardware clock.
> * parameter ts: Time value to set.
> *
> @@ -105,6 +110,9 @@ struct ptp_clock_info {
> int (*adjfreq)(struct ptp_clock_info *ptp, s32 delta);
> int (*adjtime)(struct ptp_clock_info *ptp, s64 delta);
> int (*gettime64)(struct ptp_clock_info *ptp, struct timespec64 *ts);
> + int (*getsynctime64)
> + (struct ptp_clock_info *ptp, struct timespec64 *dev,
> + struct timespec64 *sys);
This indentation looks funny, how about:
int (*getsynctime64)(struct ptp_clock_info *ptp, struct timespec64 *dev,
struct timespec64 *sys);
> int (*settime64)(struct ptp_clock_info *p, const struct timespec64 *ts);
> int (*enable)(struct ptp_clock_info *ptp,
> struct ptp_clock_request *request, int on);
> diff --git a/include/uapi/linux/ptp_clock.h b/include/uapi/linux/ptp_clock.h
> index f0b7bfe..421b637 100644
> --- a/include/uapi/linux/ptp_clock.h
> +++ b/include/uapi/linux/ptp_clock.h
> @@ -51,7 +51,9 @@ struct ptp_clock_caps {
> int n_per_out; /* Number of programmable periodic signals. */
> int pps; /* Whether the clock supports a PPS callback. */
> int n_pins; /* Number of input/output pins. */
> - int rsv[14]; /* Reserved for future use. */
> + /* Whether the clock supports precise system-device cross timestamps */
> + int precise_timestamping;
I prefer another name, like "cross_timestamping" or similar. I get
lots and lots of nube questions about PTP, and people will start
asking whether this means their packet time stamps are bad.
Also, could you update Documentation/ptp/testptp.c with the new field?
Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
