On Wed, Jul 22, 2015 at 1:46 AM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Tue, 2015-07-21 at 21:21 -0700, Lawrence Brakmo wrote: >> Replace 2 arguments (cnt and rtt) in the congestion control modules' >> pkts_acked() function with a struct. This will allow adding more >> information without having to modify existing congestion control >> modules (tcp_nv in particular needs bytes in flight when packet >> was sent). >> >> This was proposed by Neal Cardwell in his comments to the tcp_nv patch. > > Are you sure Neal suggested to pass a struct as argument ? > > It was probably a struct pointer instead.
Yes, I may not have specified, but I definitely agree we should pass the struct by pointer, as the intent is that the struct may grow over time, and we don't want to pay more overhead to copy the struct for the call. neal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
