Arend van Spriel <ar...@broadcom.com> writes: > On 07/24/2015 07:22 PM, Vineet Gupta wrote: >> On Friday 24 July 2015 08:02 PM, Kalle Valo wrote: >>> Vineet Gupta <vineet.gup...@synopsys.com> writes: >>> >>>>> There's already a generic implementation so use that instead. >>>>> --- >>>>> I'm not sure if the driver usage of atomic_or?() is correct in terms of >>>>> storage size of @val for 64 bit arches. >>>>> >>>>> Assuming LP64 programming model for linux on say x86_64: atomic_or() >>>>> callers in this driver use long (sana 64 bit) storage and pass it to >>>>> atomic_orr/atomic_or which downcasts it to 32 bits. Is that OK ? >>>>> --- >>>>> Cc: Brett Rudley <brud...@broadcom.com> >>>>> Cc: Arend van Spriel <ar...@broadcom.com> >>>>> Cc: "Franky (Zhenhui) Lin" <fran...@broadcom.com> >>>>> Cc: Hante Meuleman <meule...@broadcom.com> >>>>> Cc: Kalle Valo <kv...@codeaurora.org> >>>>> Cc: Pieter-Paul Giesberts <piete...@broadcom.com> >>>>> Cc: Daniel Kim <de...@broadcom.com> >>>>> Cc: linux-wirel...@vger.kernel.org >>>>> Cc: brcm80211-dev-l...@broadcom.com >>>>> Cc: Peter Zijlstra <pet...@infradead.org> >>>>> Cc: Ingo Molnar <mi...@kernel.org> >>>>> Cc: netdev@vger.kernel.org >>>>> Cc: linux-a...@vger.kernel.org >>>>> Cc: linux-ker...@vger.kernel.org >>>>> Signed-off-by: Vineet Gupta <vgu...@synopsys.com> >>>>> >>>>> Signed-off-by: Vineet Gupta <vgu...@synopsys.com> >>> What's the plan with this patch? Should I take it to my >>> wireless-drivers-next tree or will someone else take it? >> >> >> Per last discussion on this topic, Arend wanted to discuss abt this with >> Hante. >> I'm not taking it anyways so feel free to pick it up if you want ! > > Well, that was before your "timeline" clarification about the generic > function. One what tree is this patch based?
Yeah, if this patch depends on another patch I need to know about it. Otherwise I might break something when I apply this patch. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
