Hi David, Pablo,
I gave try to your proposed patch.
Changes in netlink_getsockopt and netlink_setsockopt are working fine.
Changes in netlink_ack looks not to be addressing the correct socket.
I will send an updated version in few minutes.
Best Regards
Christophe
On 25/08/2015 06:19, David Miller wrote:
From: Pablo Neira Ayuso <pa...@netfilter.org>
Date: Mon, 24 Aug 2015 20:56:37 +0200
On Mon, Aug 24, 2015 at 10:08:22AM +0200, Christophe Ricard wrote:
Hi Scott,
I think i understand the potential limitation of my solution.
I saw something was proposed by Jiri Benc who pushed an additional flag to
tell if the payload can be ignored in case of an error.
http://patchwork.ozlabs.org/patch/290976/
Do you think this one is acceptable ? I am not sure to understand David
last comment.
I think David suggests something like the (completely untested)
attached patch.
Yes, echo'ing the entire message back in an ACK is really pointless.
Especially since if the user really is interested in noticing ACKs
it can very easily keep the original request around and match on
sequence number, as Pablo's patch's commit message suggests.
We're stuck with the current behavior by default, but we can add the
new ACK feature to deal with the issue in the long term.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
