Sorry for lack of details. Default PHY ID is changed to 1 for final silicon. This is an coding error to be included.
________________________________________ From: David Miller [[email protected]] Sent: Thursday, August 27, 2015 7:17 PM To: Woojung Huh - C21699 Cc: [email protected] Subject: Re: [PATCH net-next 1/1] lan78xx: Change default internal PHY ID to 1 From: <[email protected]> Date: Thu, 27 Aug 2015 18:01:17 +0000 > Change default internal PHY ID to 1. > > Signed-off-by: Woojung Huh <[email protected]> This doesn't describe in enough details, this change. Why is this being changed now? How did the driver work properly with the previous value? If it worked previously, what negative things could possibly happen using the new value? You are providing zero context, and reasoning, for your change. That makes it impossible to review. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
