On Mon, Sep 14, 2015 at 5:28 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote: > On 09/11/15 20:00, Cong Wang wrote: >> >> On Fri, Sep 11, 2015 at 3:24 PM, Akshat Kakkar <akshat.1...@gmail.com> >> wrote: > > >> Hmm, I didn't know that before either. Looks like my tp->init change >> breaks it. >> >> Could you try the following patch? >> > > I would just make init() empty for this classifier (return 0?). > If someone wants to add classids ids, change() is available. > The most common (efficient) use case is what Akshat shows. > So even the check in the classify should optimize for that i.e > if (head == NULL) > do old method > else > ...
That is exactly the original code. But it is not readable at all, at least I still missed it when I touched the tp->init() part. :( Having a boolean doesn't harm anything. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
