On Wed, Sep 23, 2015 at 9:21 AM, Roopa Prabhu <[email protected]> wrote: > From: Wilson Kok <[email protected]> > > current ndo_fdb_dump and ndo_dflt_fdb_dump always return the current > fdb index. They dont return errors. Which results in fdb dumps > continuing on errors. > > In one such case where bridges and vxlan devices were involved, > bridge driver returned -EMSGSIZE on a bridge, but since it continued > on error, the next vxlan device fdb dump (which was smaller in size) > succeeded, leaving fdb idx at an inconsistent value. This > resulted in the bridge fdb entry getting skipped and vxlan > fdb entry getting dumped twice. > > This patch changes ndo_fdb_dump() to return the status and pass the > idx by reference for update. The dump aborts if non-zero status is > returned. > > Signed-off-by: Wilson Kok <[email protected]> > Signed-off-by: Roopa Prabhu <[email protected]>
Reviewed-by: Scott Feldman <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
