From: Jiri Pirko <j...@mellanox.com> This is something which I'm currently struggling with. Callers of attr_set and obj_add/del often hold not only RTNL, but also spinlock (bridge). So in that case, the driver implementing the op cannot sleep.
The way rocker is dealing with this now is just to invoke driver operation and go out, without any checking or reporting of the operation status. Since it would be nice to at least put a warning in case the operation fails, it makes sense to do this in delayed work directly in switchdev core instead of implementing this in separate drivers. And that is what this patchset is introducing. So from now on, the locking of switchdev mod ops is consistent. Caller either holds rtnl mutex or in case it does not, caller sets defer flag, telling switchdev core to process the op later in delayed work. Flush function for switchdev deferred ops can be called by op caller in appropriate location, for example after it releases spin lock, to force switchdev core to process pending ops. Jiri Pirko (7): switchdev: introduce switchdev workqueue switchdev: allow caller to explicitly request attr_set as deferred switchdev: remove pointers from switchdev objects switchdev: introduce possibility to defer obj_add/del bridge: defer switchdev fdb del call in fdb_del_external_learn rocker: remove nowait from switchdev callbacks. switchdev: assert rtnl mutex when going over lower netdevs drivers/net/ethernet/rocker/rocker.c | 13 +- include/net/switchdev.h | 14 +- net/bridge/br_fdb.c | 7 +- net/bridge/br_if.c | 3 + net/bridge/br_stp.c | 3 +- net/dsa/slave.c | 2 +- net/switchdev/switchdev.c | 289 ++++++++++++++++++++++++----------- 7 files changed, 231 insertions(+), 100 deletions(-) -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
