On Wed, Oct 21, 2015 at 11:48:25AM -0400, Sowmini Varadhan wrote: > > On sparc, deleting established SAs (e.g., by restarting ipsec) > results in unaligned access messages via xfrm_del_sa -> > km_state_notify -> xfrm_send_state_notify(). > > Even though struct xfrm_usersa_info is aligned on 8-byte boundaries, > netlink attributes are fundamentally only 4 byte aligned, and this > cannot be changed for nla_data() that is passed up to userspace. > As a result, the put_unaligned() macro needs to be used to > set up potentially unaligned fields such as the xfrm_stats in > copy_to_user_state() > > Signed-off-by: Sowmini Varadhan <sowmini.varad...@oracle.com> > --- > v2: review comment from thread: cannot use PTR_ALIGN as this would break > userspace assumptions about 4 byte alignment. Use *_unaligned() macros > as needed, instead.
This works on intel 32-bit and 64-bit as expected. Patch applied to ipsec-next, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
