On Wed, 2015-11-11 at 20:14 +0100, Hannes Frederic Sowa wrote: > On Wed, Nov 11, 2015, at 19:58, Eric Dumazet wrote:
> Can you elaborate? > > I use tail as a cookie and check if we already tried to append to the > same tail skb with skb_append_pagefrags. If during allocation, which we > do outside of the locks, a new skb arrives, we take that and try to > append again (and free the old skb), to correctly not create any > reordering in the data stream. > > You think that tail could be reused in the meanwhile? Hmmm, there is some funky stuff at least. Are you sure the __skb_queue_tail(&other->sk_receive_queue, newskb) is appropriate ? (Why not locking sk_receive_queue is safe ?) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
