On Mon, Nov 16, 2015 at 8:17 PM, David Miller <da...@davemloft.net> wrote: > So another fix could have been to do local_bh_disable() in the > udp_tunnel6_xmit_skb() helper.
This would have fixed one problem, but everywhere udp_tunnel_xmit_skb() (4, not 6) is called, iptunnel_xmit_stats is called right after it, so there would have to be a modicum of patches for all of these places too. By the way, there's something else I noticed about this in dealing with these functions: the return value of udp_tunnel_xmit_skb is different from that of udp_tunnel6_xmit_skb. Nobody is using them incorrectly, so far as I can see, but it is confusing that they return different things. I had started to clean this up and send a patch, but it got a bit invasive in drivers I shouldn't really touch. But if somebody with a bit more top-down command of things wants to poke at this, it's a low hanging fruit as far as I can see. > > Thanks again. My pleasure. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
