On Thu, 2015-11-19 at 21:20 +0100, Bjørn Mork wrote: > Eric Dumazet <eric.duma...@gmail.com> writes: > > > How many times should we crash before napi_frags_skb() returns NULL ? > .. > > return NULL; > > Huh? Now I'm lost here, too.
Well, Ethernet drivers should not feed GRO with frames with less than 14 bytes. ( eth_type_trans() would crash the same ) Lets fix buggy drivers instead of adding defensive code all over the stack. napi_gro_frags() is used by exactly 10 drivers, and I am pretty sure they are OK. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
