On Thu, Dec 03, 2015 at 04:55:44PM +0100, Dmitry Vyukov wrote: > On Thu, Dec 3, 2015 at 3:48 PM, Eric Dumazet <eduma...@google.com> wrote: > >> > >> No, I don't. But pr_debug always computes its arguments. See no_printk > >> in printk.h. So this use-after-free happens for all users. > > > > Hmm. > > > > pr_debug() should be a nop unless either DEBUG or CONFIG_DYNAMIC_DEBUG are > > set > > > > On our production kernels, pr_debug() is a nop. > > > > Can you double check ? Thanks ! > > > Why should it be nop? no_printk thing in printk.h pretty much > explicitly makes it not a nop... > > Double-checked: debug_post_sfx leads to some generated code:
Oups. I was under that impression too, that it would do sanity-check while being optimized out. I'll think on a fix for this. Thanks, Marcelo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
