On Thu, Dec 3, 2015 at 3:25 PM, Jeff Kirsher <jeffrey.t.kirs...@intel.com> wrote: > From: Jesse Brandeburg <jesse.brandeb...@intel.com> > > Ethtool priv flags implementation to enable or disable packet split, which > is a hardware feature that inspects headers and will put headers in a > separate DMA buffer from the payload data. The driver was automatically > choosing to enable packet split in some cases and this gives the user the > ability to turn it off/on explicitly. > > to query state: > ethtool --show-priv-flags ethx > > to enable: > ethtool --set-priv-flags ethx packet-split on > to disable: > ethtool --set-priv-flags ethx packet-split off > > Why would anyone want this? > Because some environments benefit from header/data split in the > receive > buffer, and the driver defaults to one or the other depending on > environment/kernel parameters. > > Why didn't you implement a generic ethtool control for this feature? > Because Intel hardware is the only hardware that supports header/data > split.
Hi Jesse, HDS is a generic feature,and even if you think only Intel hardware is the only hardware that supports that, you have multiple drivers.. right? why not go the right way of adding new netdev feature and enable/disable it through the conventional ethtool feature on/off directive? Or. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
