On December 9, 2015 10:56:31 AM PST, Andrew Lunn <[email protected]> wrote:
>commit 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus,
>not the bus' parent.") changed the parenting of PHY devices, making
>them a child of the MDIO bus, instead of the MAC device. This broken
>the Micrel PHY driver which has a deprecated feature of allowing PHY
>properties to be placed into the MAC node.
>
>In order to find the MAC node, we need to walk up the tree of devices
>until we find one with an OF node attached.
>
>Reported-by: Dinh Nguyen <[email protected]>
>Suggested-by: David Daney <[email protected]>
>Acked-by: David Daney <[email protected]>
>Fixes: 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not
>the bus' parent.")
>Signed-off-by: Andrew Lunn <[email protected]>
>---
>- if (!of_node && dev->parent->of_node)
>- of_node = dev->parent->of_node;
>+ /* The Micrel driver has a deprecated option to place phy OF
>+ * properties in the MAC node. Walk up the tree of devices to
>+ * find a device with an OF node.
>+ */
>+ dev_walker = &phydev->dev;
>+ do {
>+ of_node = dev_walker->of_node;
>+ dev_walker = dev_walker->parent;
>+
>+ } while (!of_node && dev_walker);
Looks good to me, can we also issuing à warning so people get a chance to
update their Device Tree?
Acked-by: Florian Fainelli <[email protected]>
>
> if (of_node) {
> ksz9021_load_values_from_of(phydev, of_node,
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
