Jesper, Sorry, it seems that I accidentally sent out an unfinished e-mail.
>I don't think your patch should contain this cleanup of "b4". It seems that b3 is only used for the legacy overhead part and if I remove it, b3 is not going to be used. So I figured I remove b4 put b3 instead. administrator@ubuntu:~/src/iproute2/tc$ git rev-parse HEAD 654ae881de57467642c8c2ed16ffc3a8d57fafa2 administrator@ubuntu:~/src/iproute2/tc$ grep -nHP -B 3 'b3' q_htb.c q_htb.c-273- __u64 rate64, ceil64; q_htb.c-274- SPRINT_BUF(b1); q_htb.c-275- SPRINT_BUF(b2); q_htb.c:276: SPRINT_BUF(b3); -- q_htb.c-317- sprint_size(buffer, b1), q_htb.c-318- 1<<hopt->rate.cell_log, q_htb.c-319- sprint_size(hopt->rate.mpu&0xFF, b2), q_htb.c:320: sprint_size((hopt->rate.mpu>>8)&0xFF, b3)); -- q_htb.c-322- sprint_size(cbuffer, b1), q_htb.c-323- 1<<hopt->ceil.cell_log, q_htb.c-324- sprint_size(hopt->ceil.mpu&0xFF, b2), q_htb.c:325: sprint_size((hopt->ceil.mpu>>8)&0xFF, b3)); administrator@ubuntu:~/src/iproute2/tc$ grep -nHP -B 3 'b4' q_htb.c q_htb.c-274- SPRINT_BUF(b1); q_htb.c-275- SPRINT_BUF(b2); q_htb.c-276- SPRINT_BUF(b3); q_htb.c:277: SPRINT_BUF(b4); -- q_htb.c-311- cbuffer = tc_calc_xmitsize(ceil64, hopt->cbuffer); q_htb.c-312- linklayer = (hopt->rate.linklayer & TC_LINKLAYER_MASK); q_htb.c-313- if (linklayer > TC_LINKLAYER_ETHERNET || show_details) q_htb.c:314: fprintf(f, "linklayer %s ", sprint_linklayer(linklayer, b4)); Thanks, Dima -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
