> > @@ -176,6 +170,15 @@ static int mv88e6060_setup(struct dsa_switch *ds, > > struct device *dev) > > { > > int i; > > int ret; > > + struct mv88e6060_priv *priv; > > + > > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > > + if (!priv) > > + return -ENOMEM; > > + > > + ds->priv = priv; > > + priv->bus = dsa_host_dev_to_mii_bus(ds->master_dev); > > This patch drops the checks for !bus, and thus mdiobus_write_nested can > segfault later. Maybe restore the check here?
Agreed. I will post a refresh of these patches in a few days. I made a few changes to integrate with the mdio device patchset which has recently been merged. Andrew