On Sun, 2016-01-24 at 17:49 +0100, Arnd Bergmann wrote: > I'd argue that the "(CONFIG_ARCH_MXC) || defined(CONFIG_SOC_IMX28)" > is definitely wrong, because if we ever get another ARM platform > that uses this driver, it may or may not work depending on whether > the ARCH_MXC is also set, and that is not a helpful behavior. > > Better make it simply CONFIG_ARM to keep the behavior independent > of config options. It won't change anything for now but any future > platform will probably work independent of configuration or would > require a bugfix at all. >
I agree, but I'm not really sure it's in the scope of this particular patch? Might be better to just have a separate patch with an appropriate commit message changing this ifdef. johannes
