> From: Intel-wired-lan [intel-wired-lan-boun...@lists.osuosl.org] on behalf of > Stefan Assmann [sassm...@kpanic.de] > Sent: Wednesday, February 03, 2016 12:20 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; da...@davemloft.net; sassm...@kpanic.de > Subject: [Intel-wired-lan] [PATCH net-next V2 4/6] igb: call ndo_stop() > instead of dev_close() when running offline selftest > > Calling dev_close() causes IFF_UP to be cleared which will remove the > interfaces routes and some addresses. That's probably not what the user > intended when running the offline selftest. Besides this does not happen > if the interface is brought down before the test, so the current > behaviour is inconsistent. > Instead call the net_device_ops ndo_stop function directly and avoid > touching IFF_UP at all. > > Signed-off-by: Stefan Assmann <sassm...@kpanic.de> > --- > drivers/net/ethernet/intel/igb/igb.h | 2 ++ > drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++-- > drivers/net/ethernet/intel/igb/igb_main.c | 8 ++++---- > 3 files changed, 8 insertions(+), 6 deletions(-)
Checkpatch warns that externs should be avoided in .c files, but they pre-existed and are just being flagged due to the name changing, so... Tested-by: Aaron Brown <aaron.f.br...@intel.com>
