On Mon, 2016-02-08 at 02:45 -0500, Kan Liang wrote:
[...]
> --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> @@ -1849,23 +1849,37 @@ static int i40e_set_phys_id(struct net_device *netdev,
> * 125us (8000 interrupts per second) == ITR(62)
> */
>
> -static int i40e_get_coalesce(struct net_device *netdev,
> - struct ethtool_coalesce *ec)
> +static int __i40e_get_coalesce(struct net_device *netdev,
> + struct ethtool_coalesce *ec,
> + int queue)
> {
> struct i40e_netdev_priv *np = netdev_priv(netdev);
> struct i40e_vsi *vsi = np->vsi;
> + struct i40e_pf *pf = vsi->back;
>
> ec->tx_max_coalesced_frames_irq = vsi->work_limit;
> ec->rx_max_coalesced_frames_irq = vsi->work_limit;
>
> - if (ITR_IS_DYNAMIC(vsi->rx_itr_setting))
> + /* rx and tx usecs has per queue value. If user doesn't specify the
> queue,
> + * return queue 0's value to represent.
> + */
> + if (queue < 0) {
> + queue = 0;
> + } else if (queue >= vsi->num_queue_pairs) {
> + netif_info(pf, drv, netdev, "Invalid queue value, queue range
> is 0 - %d\n",
> + vsi->num_queue_pairs - 1);
[...]Don't log this error message; it allows an unprivileged user to spam the system log. Ben. -- Ben Hutchings Sturgeon's Law: Ninety percent of everything is crap.
signature.asc
Description: This is a digitally signed message part
