Hi DaveM!
Just after ipt_ULOG.c appeared in the mainstream kernel, it seems it has
gotten more review by others than before. Timothy Ball has reported a minor
issue:
Attached is a one-liner which removes a trailing semicolon from a macro
definition. The fix is not considered as important, as it never broke
(at least on gcc).
Please apply, thanks.
--- linux-2.4.18-rc3-plain/net/ipv4/netfilter/ipt_ULOG.c Tue Feb 26 21:32:47
2002
+++ linux-2.4.18-rc3-ulog/net/ipv4/netfilter/ipt_ULOG.c Tue Feb 26 21:33:22 2002
@@ -29,7 +29,7 @@
* Specify, after how many clock ticks (intel: 100 per second) the queue
* should be flushed even if it is not full yet.
*
- * ipt_ULOG.c,v 1.15 2002/01/18 21:33:19 laforge Exp
+ * ipt_ULOG.c,v 1.16 2002/02/13 07:14:53 laforge Exp
*/
#include <linux/module.h>
@@ -61,7 +61,7 @@
#define DEBUGP(format, args...)
#endif
-#define PRINTR(format, args...) do { if (net_ratelimit()) printk(format, ## args); }
while (0);
+#define PRINTR(format, args...) do { if (net_ratelimit()) printk(format, ## args); }
+while (0)
MODULE_AUTHOR("Harald Welte <[EMAIL PROTECTED]>");
MODULE_DESCRIPTION("IP tables userspace logging module");
--
Live long and prosper
- Harald Welte / [EMAIL PROTECTED] http://www.gnumonks.org/
============================================================================
GCS/E/IT d- s-: a-- C+++ UL++++$ P+++ L++++$ E--- W- N++ o? K- w--- O- M+
V-- PS++ PE-- Y++ PGP++ t+ 5-- !X !R tv-- b+++ !DI !D G+ e* h--- r++ y+(*)
