Re: [PATCH] netfilter cosmetic cleanup

[David S. Miller]

Harald, I have just made the following fix to my tree.
Please add it to yours.

One should never set IP_DF for ICMP packets.

--- net/ipv4/netfilter/ipt_REJECT.c.~1~ Mon Feb 25 14:11:19 2002
+++ net/ipv4/netfilter/ipt_REJECT.c     Sat Mar  9 20:16:30 2002
@@ -237,11 +237,8 @@
        iph->tos=tos;
        iph->tot_len = htons(length);
 
-       /* This abbreviates icmp->send->ip_build_xmit->ip_dont_fragment */
-       if (!ipv4_config.no_pmtu_disc
-           && !(rt->u.dst.mxlock&(1<<RTAX_MTU)))
-               iph->frag_off = htons(IP_DF);
-       else iph->frag_off = 0;
+       /* PMTU discovery never applies to ICMP packets. */
+       iph->frag_off = 0;
 
        iph->ttl = MAXTTL;
        ip_select_ident(iph, &rt->u.dst, NULL);