On Tue, Apr 09, 2002 at 03:26:32PM +0900, ÀÌÈ£Àç wrote:
> I made NAT/conntrack module for xdmcp....
I've now had a look at the code. There are a couple of issues:
1. the display number NAT stuff (mistakenly named free_port_xxx functions)
doesn't belong into the conntrack module, but in the NAT module.
2. /usr/src/linux/Documentation/CodingStyle is not used throughout the code
3. the helpers are written
4. the modules are missing MODULE_LICENSE("GPL") tags
5. the modules have the same 'ports_c' bug like old versions of the ftp
helper
6. the modules are written for the old conntrack/nat API, whereas newnat
is now considered standard.
7. UDP checksumming !!
8. The IP checksum is recalculated from scratch rather than using incremental
checksumming. This results in corrupted packets traveling through nat
getting a correct checksum - the receiver cannot discover data corruption.
I'm currently resolving all those issues and will include the corrected
code into netfilter patch-o-matic.
> But I don't know how to distribute...
--
Live long and prosper
- Harald Welte / [EMAIL PROTECTED] http://www.gnumonks.org/
============================================================================
GCS/E/IT d- s-: a-- C+++ UL++++$ P+++ L++++$ E--- W- N++ o? K- w--- O- M+
V-- PS++ PE-- Y++ PGP++ t+ 5-- !X !R tv-- b+++ !DI !D G+ e* h--- r++ y+(*)
