On Sun, 23 Jun 2002, Rob Radez wrote: > Hi, > I looked at the pending patches page, tried to browse through the mailing > archives, and checked google, but didn't see if anyone had already addressed > this.
See http://marc.theaimsgroup.com/?l=linux-kernel&m=100909932003300&w=2 > fini() in net/ipv4/netfilter/ip_nat_snmp_basic.c is marked __exit, > but on Sparc32 will fail to link into the kernel because of some btfixup > magic. Can you please post the build error message and the version of binutils that you're using? > I saw two obvious ways to fix this, but only did one because I wasn't > sure about what kind of netfilter magic is going on in fini(). The attached > patch simply removes the __exit tag from fini() and lets the file link in ok. > No, the __exit tag is correct. > > The other option is to remove the br_write_lock_bh/br_write_unlock_bh calls > in fini() since they don't seem to be protecting anything. I didn't do that > because I'm not sure if there are any side effects that are being taken > advantage of here. The purpose of this lock/unlock is to synchronize with net_rx_action(). - James -- James Morris <[EMAIL PROTECTED]>
