On Mon, Feb 8, 2016 at 2:59 PM, Florian Westphal <[email protected]> wrote: > Shivani Bhardwaj <[email protected]> wrote: >> On Sun, Feb 7, 2016 at 2:55 PM, Florian Westphal <[email protected]> wrote: > >> > Seems this could be written similar to something like: >> > >> > if (info->flags & NFQ_FLAG_CPU_FANOUT) { >> > bool sep_needed = info->bypass & NFQ_FLAG_BYPASS; >> > xt_xlate_add(xl, "%sfanout ", sep_need ? "," : ""); >> > ... >> >> The pointer info used in both the versions (of NFQUEUE_xlate) is for >> different structures. Sadly, this doesn't work as v3 structure doesn't >> have a member for bypass field. > > Oh, right. However bypass & flags overlap -- I think you could just use > info->flags & NFQ_FLAG_BYPASS. > > If you look at NFQUEUE_parse_v3() it just calls NFQUEUE_parse_v2() with > the v3 structure.
Yes, the code looks better now. Thanks a lot, Florian. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
