Support explicitly names implicitly declared sets.

Also change the template names for literal sets and maps to use identifiers
that can not clash with user supplied identifiers.

Signed-off-by: Patrick McHardy <[email protected]>
---
 src/evaluate.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/evaluate.c b/src/evaluate.c
index 9c8add3..aa9fa43 100644
--- a/src/evaluate.c
+++ b/src/evaluate.c
@@ -87,6 +87,7 @@ static int __fmtstring(3, 4) set_error(struct eval_ctx *ctx,
 }
 
 static struct expr *implicit_set_declaration(struct eval_ctx *ctx,
+                                            const char *name,
                                             const struct datatype *keytype,
                                             unsigned int keylen,
                                             struct expr *expr)
@@ -97,7 +98,7 @@ static struct expr *implicit_set_declaration(struct eval_ctx 
*ctx,
 
        set = set_alloc(&expr->location);
        set->flags      = SET_F_ANONYMOUS | expr->set_flags;
-       set->handle.set = xstrdup(set->flags & SET_F_MAP ? "map%d" : "set%d");
+       set->handle.set = xstrdup(name),
        set->keytype    = keytype;
        set->keylen     = keylen;
        set->init       = expr;
@@ -988,7 +989,8 @@ static int expr_evaluate_map(struct eval_ctx *ctx, struct 
expr **expr)
 
        switch (map->mappings->ops->type) {
        case EXPR_SET:
-               mappings = implicit_set_declaration(ctx, ctx->ectx.dtype,
+               mappings = implicit_set_declaration(ctx, "__map%d",
+                                                   ctx->ectx.dtype,
                                                    ctx->ectx.len, mappings);
                mappings->set->datatype = ectx.dtype;
                mappings->set->datalen  = ectx.len;
@@ -1199,7 +1201,9 @@ static int expr_evaluate_relational(struct eval_ctx *ctx, 
struct expr **expr)
                /* A literal set expression implicitly declares the set */
                if (right->ops->type == EXPR_SET)
                        right = rel->right =
-                               implicit_set_declaration(ctx, left->dtype, 
left->len, right);
+                               implicit_set_declaration(ctx, "__set%d",
+                                                        left->dtype,
+                                                        left->len, right);
                else if (!datatype_equal(left->dtype, right->dtype))
                        return expr_binary_error(ctx->msgs, right, left,
                                                 "datatype mismatch, expected 
%s, "
-- 
2.5.5

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to