Hi Arturo,

On man, 2016-10-17 at 09:41 +0200, Arturo Borrero Gonzalez wrote:
> On 16 October 2016 at 15:42, Anders K. Pedersen | Cohaesio
> <a...@cohaesio.com> wrote:
> > 
> > From: Anders K. Pedersen <a...@cohaesio.com>
> > 
> > Introduce basic infrastructure for nftables rt expression for
> > routing
> > related data. Initially "rt classid" is implemented identical to
> > "meta
> > rtclassid", since it is more logical to have this match in the
> > routing
> > expression going forward.
> > 

> > +static const struct nft_expr_ops *
> > +nft_rt_select_ops(const struct nft_ctx *ctx,
> > +                 const struct nlattr * const tb[])
> > +{
> > +       if (tb[NFTA_RT_KEY] == NULL)
> > +               return ERR_PTR(-EINVAL);
> > +
> > +       if (tb[NFTA_RT_DREG])
> > +               return &nft_rt_get_ops;
> > +
> > +       return ERR_PTR(-EINVAL);
> > +}
> 
> I don't understand why you use select_ops.
> 
> Do you plan to extend this expr behaviour in the near future?

No, I have changed this to use ".ops = &nft_rt_get_ops" for patch 2-5.
I have also fixed the comment for enum nft_rt_keys in patch 1 and the
patches for libnftnl and nftables.

I'll hold on to them for a few days to see, if there are other
comments, and then post version 2.

Thanks for reviewing.

Regards,
Anders K. Pedersen
N�����r��y����b�X��ǧv�^�)޺{.n�+���z���׫u�ޖ)����w*jg��������ݢj/���z�ޖ��2�ޙ����&�)ߡ�a�����G���h��j:+v���w��٥

Reply via email to