when debugging nft with invalid object type (during development), this will crash here with null deref. Print (unknown) instead if obj->ops is null.
Signed-off-by: Florian Westphal <[email protected]> --- src/object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/object.c b/src/object.c index 62fa48afa2a1..773eff6a5a18 100644 --- a/src/object.c +++ b/src/object.c @@ -396,10 +396,11 @@ static int nftnl_obj_snprintf_dflt(char *buf, size_t size, const struct nftnl_obj *obj, uint32_t type, uint32_t flags) { + const char *name = obj->ops ? obj->ops->name : "(unknown)"; int ret, len = size, offset = 0; ret = snprintf(buf, size, "table %s name %s use %u [ %s ", - obj->table, obj->name, obj->use, obj->ops->name); + obj->table, obj->name, obj->use, name); SNPRINTF_BUFFER_SIZE(ret, size, len, offset); if (obj->ops) { -- 2.10.2 -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
